TPT-4463: Add integration tests for RDMA interfaces by mawilk90 · Pull Request #999 · linode/linodego

mawilk90 · 2026-06-30T09:27:46Z

📝 Description

Integration tests for RDMA interfaces

Notes:

DevCloud tests may fail in CI because RDMA functionality is available on DevCloud only at the moment

✔️ How to Test

Some local setup is needed before RDMA tests run.

RDMA integration tests:

DevCloud:
make fixtures TEST_ARGS="-run TestVPC_WithRDMAType"
make fixtures TEST_ARGS="-run TestVPC_Subnet_WithRDMAType"
make fixtures TEST_ARGS="-run TestInstance_CreateWithRDMAVPCInterfaces" <- commented out as it requires manual infra setup at the moment

Related fixes and refactors:

DevCloud:
make test-int TEST_ARGS="-run TestVPC_CreateGet_smoke"
make test-int TEST_ARGS="-run TestVPC_Subnet_Create"
Prod:
make test-int TEST_ARGS="-run TestVPC_List"
make test-int TEST_ARGS="-run TestVPC_Update"
make test-int TEST_ARGS="-run TestVPC_Create_Invalid_data"
make test-int TEST_ARGS="-run TestVPC_Update_Invalid"
make test-int TEST_ARGS="-run TestVPC_Subnet_Create_Invalid_data"
make test-int TEST_ARGS="-run TestVPC_Subnet_Update_Invalid_data"
make test-int TEST_ARGS="-run TestLKECluster_Enterprise_BYOVPC_smoke"

Copilot

Pull request overview

This PR extends the Linode Go client’s VPC + interface models to represent RDMA-capable VPCs/interfaces and adds unit + integration coverage (plus fixtures) to validate (un)marshalling and key RDMA workflows. It’s intended to pair with the feature work in #988 and adds the test/fixture layer around that functionality.

Changes:

Add VPCType (regular/rdma) to VPC and VPC subnet models and wire it into VPC create options.
Add RDMA VPC interface models/options plus a new instance-create interface option type that supports RDMA VPC interfaces, with InstanceCreateOptions marshaling support.
Add unit tests + integration tests + VCR fixtures for RDMA VPCs and RDMA interfaces.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vpc.go	Introduces `VPCType` and adds `vpc_type` support to VPC and create options.
vpc_subnet.go	Adds `vpc_type` to VPC subnet responses.
interfaces.go	Adds RDMA VPC interface models/options and instance-create interface option type.
instances.go	Adds `LinodeInstanceInterfaces` and extends `InstanceCreateOptions.MarshalJSON` conflict + serialization logic.
test/unit/rdma_vpc_test.go	Unit coverage for RDMA VPC type, RDMA interface (get/list/update), and marshaling semantics.
test/unit/fixtures/vpc_rdma_get.json	Unit fixture for RDMA VPC GET response.
test/unit/fixtures/vpc_rdma_create.json	Unit fixture for RDMA VPC create response/validation.
test/unit/fixtures/interface_update_rdma_vpc.json	Unit fixture for RDMA interface update response.
test/unit/fixtures/interface_list_with_rdma.json	Unit fixture for listing interfaces including RDMA entries.
test/unit/fixtures/interface_get_rdma_vpc.json	Unit fixture for RDMA interface GET response.
test/integration/vpc_test.go	Integration test refactor + adds RDMA VPC create/get/list filter coverage.
test/integration/vpc_subnet_test.go	Integration coverage for subnet `vpc_type` and RDMA subnet workflows.
test/integration/lke_clusters_test.go	Updates helper return signature usage due to createVPC refactor.
test/integration/instance_interfaces_test.go	Switches instance-create tests to `LinodeInstanceInterfaces` and adds RDMA interface integration test.
test/integration/fixtures/TestVPC_CreateGet.yaml	Updates recorded interactions to include `vpc_type` and devcloud URLs.
test/integration/fixtures/TestVPC_Create_Invalid.yaml	Updates recorded invalid-label interaction and message.
test/integration/fixtures/TestInstance_CreateWithLinodeInterfaces.yaml	Updates recorded instance-create interaction for updated VPC/subnet responses and devcloud URLs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yec-akamai · 2026-07-07T19:58:32Z

Let me update the base branch and see if it fixes the workflow issues and clean up the git history

yec-akamai · 2026-07-07T20:28:57Z

There are a few things not compatible from merging v2. I've put up a PR to address them: #1003

After it merged you should be good to rebase from the proj branch into your branch to clean up the commit history. Although it's probably some conflicts to fix. I wonder if it's easier to check out a brand new branch though.

psnoch-akamai · 2026-07-08T09:03:58Z

@mawilk90 and @yec-akamai, how about rebase of proj/rdma-interfaces branch?

# Conflicts: # interfaces.go # regions.go # test/unit/fixtures/interface_list_with_rdma.json # test/unit/rdma_vpc_test.go # vpc.go

Current implementation of vpcCreateOptionsCheck verifies fields copied from VPC so comparing opts.Label == vpc.Label etc. is just comparing a value to itself —> good is always true.

…rfaceCreateOptions

…ceWithLinodeInterfaces

…nges needed

mawilk90 · 2026-07-09T06:36:41Z

@mawilk90 and @yec-akamai, how about rebase of proj/rdma-interfaces branch?

@psnoch-akamai @yec-akamai I rebased the code so it should be fine now

mawilk90 requested review from a team as code owners June 30, 2026 09:27

mawilk90 requested review from jriddle-linode and removed request for a team June 30, 2026 09:27

mawilk90 added the new-feature for new features in the changelog. label Jun 30, 2026

mawilk90 requested a review from a team June 30, 2026 09:27

mawilk90 added the testing for updates to the testing suite in the changelog. label Jun 30, 2026

mawilk90 requested review from Copilot, lgarber-akamai, psnoch-akamai and yec-akamai and removed request for a team, jriddle-linode and lgarber-akamai June 30, 2026 09:27

Copilot started reviewing on behalf of mawilk90 June 30, 2026 09:28 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread test/integration/instance_interfaces_test.go Outdated

Comment thread test/integration/instance_interfaces_test.go Outdated

Comment thread test/integration/instance_interfaces_test.go Outdated

Comment thread test/integration/vpc_test.go

mawilk90 marked this pull request as draft June 30, 2026 11:10

mawilk90 changed the base branch from main to proj/rdma-interfaces July 7, 2026 08:19

mawilk90 changed the base branch from proj/rdma-interfaces to main July 7, 2026 09:36

mawilk90 changed the base branch from main to proj/rdma-interfaces July 7, 2026 09:39

mawilk90 changed the base branch from proj/rdma-interfaces to main July 7, 2026 10:00

mawilk90 changed the base branch from main to proj/rdma-interfaces July 7, 2026 10:20

mawilk90 marked this pull request as ready for review July 7, 2026 11:14

yec-akamai and others added 3 commits July 9, 2026 07:42

init

7fb2779

# Conflicts: # interfaces.go # regions.go # test/unit/fixtures/interface_list_with_rdma.json # test/unit/rdma_vpc_test.go # vpc.go

address comments for omitzero

23fd365

Refactor vpcCreateOptionsCheck to use createOpts

54740a7

Current implementation of vpcCreateOptionsCheck verifies fields copied from VPC so comparing opts.Label == vpc.Label etc. is just comparing a value to itself —> good is always true.

mawilk90 added 16 commits July 9, 2026 07:44

Update fixtures

04c6cc4

Create int tests for VPC and VPC Subnet with RDMA type

57a5d2c

Add assertion for regular VPC type

f3c7279

Update vpcCreateOptionsCheck to use require

de55c0c

Update error msg in TestVPC_Update_Invalid

f2cb55d

Update fixtures for TestVPC_List tests

0b4a3bd

Update err msg for invalid label in VPC and Subnet tests

96d0b8e

Add negative TCs for RDMA VPC with IPv6

a2453fd

Create int test for Linode instance with RDMA interfaces

acc5ac4

Refactor createInstanceWithLinodeInterfaces to use LinodeInstanceInte…

9f57dc0

…rfaceCreateOptions

Refactor TestInstance_CreateWithRDMAVPCInterfaces to use createInstan…

bc18d1f

…ceWithLinodeInterfaces

Small refactor & fixture update

5a31809

Linter

c9872fa

Comment out TestInstance_CreateWithRDMAVPCInterfaces due to infra cha…

8adc5a6

…nges needed

Update comment for TestVPC_WithRDMATypeIPv6_Fail

951445c

Update fixtures for TestVPC_CreateGet_smoke and TestVPC_Subnet_Create

763321a

mawilk90 force-pushed the feature/TPT-4463-add-int-tests-for-rdma-interfaces branch from 6bb9e2b to 763321a Compare July 9, 2026 05:55

Update fixtures and TestVPC_IPv4Ranges to return 4 vals in createVPC

fe27290

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TPT-4463: Add integration tests for RDMA interfaces#999

TPT-4463: Add integration tests for RDMA interfaces#999
mawilk90 wants to merge 20 commits into
linode:proj/rdma-interfacesfrom
mawilk90:feature/TPT-4463-add-int-tests-for-rdma-interfaces

mawilk90 commented Jun 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai commented Jul 7, 2026 •

edited

Loading

Uh oh!

yec-akamai commented Jul 7, 2026

Uh oh!

psnoch-akamai commented Jul 8, 2026

Uh oh!

mawilk90 commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mawilk90 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yec-akamai commented Jul 7, 2026

Uh oh!

psnoch-akamai commented Jul 8, 2026

Uh oh!

mawilk90 commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mawilk90 commented Jun 30, 2026 •

edited

Loading

yec-akamai commented Jul 7, 2026 •

edited

Loading